fix: Multi-thread recreate view/table gives error #16465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
zhyass
changed the title
drmingdrmer
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dantengsky and @sundy-li)
drmingdrmer
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Reviewable status:
|
Nice shot! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
* fix: Multi-thread recreate view gives error * fix test
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
When executing
DROP TABLE IF EXISTS, if the table metadata contains adrop_onflag, indicating that the table has already been marked for deletion, no error will be returned. This ensures the operation is idempotent, preventing unnecessary errors from being raised if the table has already been dropped.Tests
Type of change
This change is